Re: contradiction in boot/i386/pc/boot.S

[Robert Millan]

On Tue, Jan 08, 2008 at 01:24:25PM -0500, Pavel Roskin wrote:
> On Tue, 2008-01-08 at 11:50 +0100, Robert Millan wrote:
> > boot_drive_check:
> >         jmp     1f      /* grub-setup may overwrite this jump */
> >         testb   $0x80, %dl
> >         jnz     1f
> >         movb    $0x80, %dl
> > 1:
> > 
> > However, if 0x80 is really "the only possible boot drive", that means the
> > test is pointless and can be replaced with:
> 
> No, I was wrong, I misread "testb" as "cmpb".  Values such as 0x81 are
> valid and should be preserved.

Yeah I was going to point that..

> Please ignore my previous message.

All of it, or just partly ?

-- 
Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call, if you are unable to speak?
(as seen on /.)