Re: [PATCH] mkdevicemap for Cygwin

[Christian Franke]

Robert Millan wrote:
> > ...
> > Yes, it would work now, because the patch also fixes this bug :-) 
> 
> Ok, so in that case you don't need...
> 
> > +#ifndef __CYGWIN__
> > static void
> > get_ide_disk_name (char *name, int unit)
> > {
> > @@ -213,6 +217,7 @@ get_ide_disk_name (char *name, int unit)
> > *name = 0;
> > #endif
> > }
> > +#endif /* __CYGWIN__ */
> > 
> > [...]
> > +#ifndef __CYGWIN__
> > /* IDE disks.  */
> > for (i = 0; i < 8; i++)
> > {
> > @@ -431,6 +440,7 @@ make_device_map (const char *device_map,
> > num_hd++;
> > }
> > }
> > +#endif /* __CYGWIN__ */
> 
> ...because you already fixed the problem in:
> 
> > -  /* If DEVICE is empty, just return 1.  */
> > +  /* If DEVICE is empty, just return error.  */
> > if (*device == 0)
> > -    return 1;
> > -
> > +    return 0;
> 
> ?

Yes. I you want this alternative instead, and there are no other issues
with this patch, I'm happy to post a new version.

Christian