[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Fix for linker build ID in Fedora 8

From: Robert Millan
Subject: Re: [PATCH] Fix for linker build ID in Fedora 8
Date: Sun, 18 Nov 2007 07:50:51 +0100
User-agent: Mutt/1.5.13 (2006-08-11)

On Wed, Nov 14, 2007 at 02:39:02AM -0500, Pavel Roskin wrote:
> Hello!
> [Sorry for not replying earlier.  All messages from my account
> were getting lost.  Anyway, I'll need to retire that address due to
> massive spam.]
> Here's an alternate patch for the issue that appeared on Fedora 8.  The
> linker adds a "build ID" ( by default.  That section
> makes objcopy create output files about 128M long when asked to use
> binary format.  Needless to say, they are not suitable as grub images.
> Also, the build ID section breaks the test for objcopy in the configure
> script.
> This patch is less intrusive than the one I posted earlier, so I hope it
> will be accepted.
> 2007-10-29  Pavel Roskin  <address@hidden>
>       * Test if '--build-id=none' is supported by the
>       linker.  Add it to TARGET_LDFLAGS if possible.  Build ID
>       interferes with objcopy.
>       * aclocal.m4 (grub_PROG_OBJCOPY_ABSOLUTE): Use LDFLAGS when
>       linking, so that build ID doesn't break the test.

Looks fine to me.  Seeing that there were no objections after a few days, I
suggest you check it in.

Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call, if you are unable to speak?
(as seen on /.)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]