grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Allow build without dirent.d_type, fix "ls (host)" crash


From: Christian Franke
Subject: Re: [PATCH] Allow build without dirent.d_type, fix "ls (host)" crash
Date: Sat, 10 Nov 2007 19:16:40 +0100
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.6) Gecko/20070802 SeaMonkey/1.1.4

Marco Gerards wrote:
...
2007-11-09  Christian Franke  <address@hidden>

        * util/hostfs.c (is_dir): New function.
        (grub_hostfs_dir):  Handle missing dirent.d_type case.
        (grub_hostfs_read): Add missing fseek().
        (grub_hostfs_label): Clear label pointer.  This fixes a crash
        of grub-emu on "ls (host)".

Looks fine to me.

Thanks.

btw, when do you use (host)?  It's intended as a debugging tool.

It was there, it didn't work, and it breaked remaining grub-emu device access at all. So I fixed it :-)

Christian





reply via email to

[Prev in Thread] Current Thread [Next in Thread]