[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] fix serial console on LinuxBIOS

From: Marco Gerards
Subject: Re: [PATCH] fix serial console on LinuxBIOS
Date: Fri, 09 Nov 2007 16:30:44 +0100
User-agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux)

Robert Millan <address@hidden> writes:

> This patch fixes serial console on LinuxBIOS.
> I'd appreciate comments (specially on the <grub/machine/machine.h> addition).
> -- 
> Robert Millan
> <GPLv2> I know my rights; I want my phone call!
> <DRM> What use is a phone call, if you are unable to speak?
> (as seen on /.)

No header ;)

>       * include/grub/i386/efi/machine.h: New file.
>       * include/grub/i386/linuxbios/machine.h: Likewise.
>       * include/grub/i386/pc/machine.h: Likewise.
>       * include/grub/powerpc/ieee1275/machine.h: Likewise.
>       * include/grub/sparc64/ieee1275/machine.h: Likewise.
>       * term/i386/pc/serial.c: Include <grub/machine/machine.h>.
>       (serial_hw_io_addr): New variable.
>       (serial_hw_get_port): Obtain port address from `serial_hw_io_addr'
>       instead of `(unsigned short *) 0x400'.

This seems fine to me.  What is your intended use for machine.h?  More
than just this?

Perhaps we can even use autoconf to define this in config.h?  That
would be better I think.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]