[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: grub2 ChangeLog term/i386/pc/serial.c

From: Robert Millan
Subject: Re: grub2 ChangeLog term/i386/pc/serial.c
Date: Wed, 7 Nov 2007 22:28:32 +0100
User-agent: Mutt/1.5.13 (2006-08-11)

On Wed, Nov 07, 2007 at 10:35:17PM +0200, Vesa Jääskeläinen wrote:
> > grub_inb() and grub_outb() are based on the inb()/outb() implementation
> > from glibc headers, so I kept the same arguments for consistency.
> I see... Once again inconsistency introduced by Unix folks... as AT&T
> assembler wouldn't be enough, they then poisons C libs too... oh well...
> another thing to try to keep in mind...

I always thought the Right Way to do this would be implement it in GCC,
so that you can do things like:

  __some_magic__(PORT_ADDR) |= 0x80;

which is much more beatufil than either of:

  outb (PORT_ADDR, inb (PORT_ADDR) | 0x80);

  outb (inb (PORT_ADDR) | 0x80, PORT_ADDR);

don't you think?

(now if someone is bored and takes my suggestion to gcc-patches, that'd make
my day...)

Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call, if you are unable to speak?
(as seen on /.)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]