[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: grub2 ChangeLog term/i386/pc/serial.c

From: Vesa Jääskeläinen
Subject: Re: grub2 ChangeLog term/i386/pc/serial.c
Date: Wed, 07 Nov 2007 22:35:17 +0200
User-agent: Thunderbird (Windows/20070728)

Robert Millan wrote:
> On Tue, Nov 06, 2007 at 11:33:44PM +0200, Vesa Jääskeläinen wrote:
>>>             * term/i386/pc/serial.c (serial_hw_put): Switch order of 
>>> arguments
>>>             in grub_outb() calls.
>> Why on earth those parameters are reversed anyway :) ?
> My fault :-)
> When I replaced inb() and outb() in that file, I assumed they would have
> the same semantics as grub_inb() and grub_outb().

Just to be clear, I would have understood your rational ordering better
than current version ;)

> grub_inb() and grub_outb() are based on the inb()/outb() implementation
> from glibc headers, so I kept the same arguments for consistency.

I see... Once again inconsistency introduced by Unix folks... as AT&T
assembler wouldn't be enough, they then poisons C libs too... oh well...
another thing to try to keep in mind...

reply via email to

[Prev in Thread] Current Thread [Next in Thread]