[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Fix eisa_mmap evaluation, add memory existence check

From: Christian Franke
Subject: Re: [PATCH] Fix eisa_mmap evaluation, add memory existence check
Date: Tue, 23 Oct 2007 22:36:43 +0200
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv: Gecko/20070802 SeaMonkey/1.1.4

Robert Millan wrote:
On Tue, Oct 23, 2007 at 09:06:16PM +0200, Christian Franke wrote:
This patch fixes the broken evaluation of the E801 EISA memory map. The shift was too much, the high word is already shifted :-) The bug was hidden until the E820 memory map evaluation was broken due to the struct packing issue fixed in my last patch.

The extra handling of "0x3C00" case is IMO not necessary. Regions are merged a few lines later.

During testing, I added a primitive memory to detect such problems early. It was difficult to find why grub crashes during module load.

Is this related to Cygwin?

No. The EISA memory map bug would crash GRUB on all systems w/o E820 memory map support.

The memory existence test is not necessary of course, but helped to check that memory map evaluation was finally working properly.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]