Re: [PATCH] startup.S does not find includes

[Robert Millan]

On Mon, Oct 22, 2007 at 06:31:22AM -0700, walt wrote:
> Christian Franke wrote:
> >Robert Millan wrote:
> >>On Sun, Oct 21, 2007 at 06:56:21PM +0200, Christian Franke wrote:
> >>>Hi,
> >>>
> >>>some recent checkin appearently introduces the following regression:
> >>>
> >>>Compilation fails if configure'd outside of $(srcdir).
> >>>#include "kern/i386/realmode.S" and "kern/i386/loader.S" fail in 
> >>>startup.S.
> >>
> >>Uhm I just noticed that previously existing #includes have relative 
> >>paths,
> >>e.g.:
> >>
> >>#include "lzo1x.S"
> >>
> >>Perhaps I should have done the same instead of adding new include dirs.
> >>
> >>Thoughts?
> >>
> >
> >For kern/i386/pc/startup.S:
> >
> >#include "../realmode.S" // include pc-independent i386 realmode code
> >
> >Should work without any -I option.
> 
> I considered that, but wouldn't it break compilation when building
> in-tree, ie without an obj directory?

Why would it?

-- 
Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call, if you are unable to speak?
(as seen on /.)