[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] grub2 for Cygwin
From: |
Vesa Jääskeläinen |
Subject: |
Re: [PATCH] grub2 for Cygwin |
Date: |
Sun, 21 Oct 2007 16:18:02 +0300 |
User-agent: |
Thunderbird 2.0.0.6 (Windows/20070728) |
Christian Franke wrote:
> Robert Millan wrote:
>> On Tue, Oct 16, 2007 at 02:03:35PM +0200, Christian Franke wrote:
>> Could you send it as an attachment? This way it's easier to comment on
>> it contextualy.
> I didn't want to send a ~45KB attachment in my first mail to this list ;-)
> Patch is attached.
I see... Actually this patch has to be splitted to multiple different
patches as not all changes seem to be related to Cygwin building. And it
makes it much easier to get approved in smaller slices. And for each
patch, describe in email why did you made changes related to patch. I
see that there are some good changes that should be applied whether it
is for cygwin build or not. But lets keep their commenting to single
features (patches) :)