Re: [PATCH] Build issues with parallel make

[Simon Peter]

> > and correcting the two header file dependencies (not
> > the binaries depend on the headers, but one of the source files,
> > respectively).
> This doesn't sound right.  Since the source files (grub-setup.c,
> grub-probe.c) are not dynamicaly generated, make doesn't need a rule
> to "build" them.  Why did you need to change this?

The dependencies are actually generated for the object files. Before,
the Ruby script would make the objects only depend on their respective
sources. However, you still define the dependency for the source files.
I think this is better because the Ruby script generates the rules to
build the object files and object files might have different names on
different architectures, whereas the source file names always stay
identical. And it's also not totally illogical: Since the source files
include the headers, they also depend on them in a sense.

> Though, if the rmk needs to be modified, take into account there are
> other targets which probably share the same problem
> (powerpc-ieee1275, i386-efi).

You're right. I fixed them as well.

> Btw, could you please include a ChangeLog entry with your patch?

Sure. The new version (including aforementioned fixes) against latest
CVS head is attached.

Simon

new-correct_dependencies.dif
Description: video/dv