grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] bug fix for the ntfs driver


From: Bean
Subject: Re: [PATCH] bug fix for the ntfs driver
Date: Tue, 21 Aug 2007 10:21:03 +0800

Hi,

The problem is caused by the structure of compressed files. In ntfs,
16 clusters is the basic compressed unit. The original code assume
that the file will break in 16 cluster long blocks, but in fact, the
blocks will be merged if they are stored next to to each other on
disk. The new code fix this problem.

       * fs/ntfs.c (read_block): Fix a bug caused by adjacent blocks.

On 8/20/07, Marco Gerards <address@hidden> wrote:
> Bean <address@hidden> writes:
>
> Hi Bean,
>
> > This patch fix a bug in the ntfs driver which occurs when accessing
> > certain compressed files.
>
> Sorry again for the late reply...
>
> > 2007-08-16  Bean  <address@hidden>
> >
> >       * fs/ntfs.c (read_block): Bug fix for compressed files.
>
> Please describe in the changelog entry what changed, not the
> functional effect.  Examples can be:
>
> - Fix off-by-one error.
> - Initialize variable to 9.
> - Check if memory allocation fails, in that case return an error.
>
> etc.
>
> Unfortunately I do not understand your change, why it is required and
> what the error was.  Can you please update the changelog entry?
>
> Thanks,
> Marco
>
>
>
> _______________________________________________
> Grub-devel mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/grub-devel
>


-- 
Bean




reply via email to

[Prev in Thread] Current Thread [Next in Thread]