Re: patch to get rid of hardcoded grub_*_init in grub-probe / grub-setup

[Marco Gerards]

Robert Millan <address@hidden> writes:

> As suggested by Marco, I adapted the framework to generate grub_init_all
> / grub_fini_all functions from grub-emu to also be used on grub-probe and
> grub-setup.
>
> Any comments on the patch?

Two comments on the changelog entry.  If you can fix those, you can
apply the patch.

--
Marco



> 2007-06-27  Robert Millan  <address@hidden>
>
>       * geninitheader.sh: Process file specified in first parameter rather
>       than hardcoding grub_modules_init.lst.
>       * geninit.sh: Likewise.  Also, construct header name dynamicaly rather
>       than hardcoding grub_modules_init.h.
>
>       * conf/common.rmk: Rename grub_modules_init.[ch] files associated with
>       grub-emu to grub_emu_init.[ch].  Add rules to build analogous
>       grub_probe_init.[ch] and grub_setup_init.[ch].
>
>       * conf/powerpc-ieee1275.rmk (grub_emu_DEPENDENCIES): Replace
>       grub_modules_init.h with grub_emu_init.h.
>       (grub_probe_*): Add new grub_probe_init.[ch] files.

Please do list the functions, instead of using *.

>       * conf/i386-efi.rmk: Likewise.
>       * conf/i386-pc.rmk: Likewise.
>       (grub_setup_*): Add new grub_setup_init.[ch] files.

Same here.

>       * util/grub-emu.c: Replace grub_modules_init.h with grub_emu_init.h.
>       * util/grub-probe.c: Include grub_probe_init.h.  Use grub_init_all()
>       to initialize modules rather than a list of hardcoded functions.
>       * util/i386/pc/grub-setup.c: Include grub_setup_init.h.  Use
>       grub_init_all() to initialize modules rather than a list of hardcoded
>       functions.

--
Marco