Re: Host filesystem access

[Robert Millan]

On Thu, May 17, 2007 at 11:28:12PM +0200, Marco Gerards wrote:
> +    grub_error (GRUB_ERR_BAD_FS, "not a affs filesystem");
> +    grub_error (GRUB_ERR_BAD_FS, "not a hfsplus filesystem");
> +    grub_error (GRUB_ERR_BAD_FS, "not a sfs filesystem");

I think these should be "an" (but not sure about all them, any native English
speaker around?).

> diff -u -p -u -p -r1.34 grub-emu.c
> --- util/grub-emu.c   16 May 2007 21:38:44 -0000      1.34
> +++ util/grub-emu.c   17 May 2007 21:17:02 -0000
> @@ -185,6 +185,8 @@ main (int argc, char *argv[])
>    /* XXX: This is a bit unportable.  */
>    grub_util_biosdisk_init (args.dev_map);
>  
> +  grub_hostfs_init ();
> +
>    grub_init_all ();

I find it counter-intuitive that grub_init_all doesn't imply grub_hostfs_init;
if there's a design reason for this, maybe the function should be renamed ?
(how about grub_filesystems_init + grub_partmaps_init ?)

-- 
Robert Millan

My spam trap is address@hidden  Note: this address is only intended
for spam harvesters.  Writing to it will get you added to my black list.