[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Fix build of sparc64 port & implement setjmp/longjmp
From: |
Hollis Blanchard |
Subject: |
Re: [PATCH] Fix build of sparc64 port & implement setjmp/longjmp |
Date: |
Sun, 04 Mar 2007 12:34:38 -0600 |
On Sun, 2007-03-04 at 16:14 +0100, Vincent Pelletier wrote:
> Hi.
>
> Here is a (mostly) maintainance patch for sparc64 port.
> It only fixes the build and implements setjmp/longjmp so that one can jump to
> rescue mode.
It looks like you also introduce new ELF relocations, I guess because
you've stumbled across modload errors?
> I prefer to post the patch for validation before commiting, it's been too
> long
> I haven't post to go on my own :) . (changelog is in the diff :p ).
Could you remove the commented-out code in setjmp.S please?
Also, it doesn't look like you're actually calling grub_claim_heap(). In
that case, why add it to kern/sparc64/ieee1275/init.c ?
> +typedef grub_uint64_t grub_jmp_buf[10];
...
> -grub_jmp_buf grub_exit_env;
> +grub_jmp_buf grub_exit_env __attribute__ ((__aligned__(8)));
grub_jmp_buf should already be 8-byte aligned (because grub_uint64_t is,
right?), so you should leave grub_exit_env alone.
-Hollis