Re: __unused

[Hollis Blanchard]

On Wed, 2006-11-01 at 13:48 +0100, Johan Rydberg wrote:
> Hollis Blanchard <address@hidden> writes:
> 
> > --- grub2-cvs.orig/include/grub/types.h     2006-10-31 19:06:47.000000000 
> > -0600
> > +++ grub2-cvs/include/grub/types.h  2006-10-31 19:06:58.000000000 -0600
> > @@ -23,6 +23,8 @@
> >  #include <config.h>
> >  #include <grub/cpu/types.h>
> >  
> > +#define __unused __attribute__ ((unused))
> > +
> 
> First when I saw this it made me wanna comment on it, and tell you
> that defines should all be in uppercase.  But then I poked through the
> code, and saw the usage of it, and it looked quite nice, with the
> exception of the __-prefix.  There are a lot of "common" words that
> are keywords in C; inline, const and auto for example.  Maybe we
> should make "unused" a reserved keyword in GRUB?  That would allow
> us to write code like;

I left it as "__unused" for now, to match Linux's usage. (We can change
it later if needed.)

>   int
>   grub_foo (int x, unused int foo)
>   {
>     ...
>   }

I believe gcc attributes can't be used as naturally as this; it would
have to be "int unused foo" or "int unused *foo" (from memory).

-Hollis