Re: [PATCH] don't assume floppy device exists

[Robert Millan]

On Thu, Sep 14, 2006 at 08:40:53PM +0200, Marco Gerards wrote:
> Robert Millan <address@hidden> writes:
> 
> > grub-install used to fail with "/dev/fd0 not found" errors.  See attached 
> > patch.
> 
> Thanks for the patch.  Just keep sending them. ;-)

:)

> > 2006-09-14  Robert Millan  <address@hidden>
> >
> >     * util/i386/pc/grub-mkdevicemap.c:  Make sure floppy device exists
> >     before adding it to device.map.
> 
> I think it would be better to say "the floppy drive", no?

As you like (using "the floppy device" after clarification via IRC).

> > +      if (stat (name, &st) < 0)
> > +   break;
> 
> The indentation looks a bit weird in my mailclient.  Please make sure
> the b of break is below the space after if.

It is.  I copied the indentation from the printf below (tab + spaces).

> After that, feel free to commit it.

Done.

-- 
Robert Millan

My spam trap is address@hidden  Note: this address is only intended for
spam harvesters.  Writing to it will get you added to my black list.