grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[patch] PowerPC: Removed duplicate query..


From: Vesa Jääskeläinen
Subject: [patch] PowerPC: Removed duplicate query..
Date: Thu, 27 Apr 2006 22:18:05 +0300
User-agent: Thunderbird 1.5.0.2 (Windows/20060308)

Hi,

I was looking at PowerPC's kernel code at one point and noticed that
"/chosen" is queried multiple times. This message contains attachment
removing this duplication.

Thanks,
Vesa Jääskeläinen
Index: ChangeLog
===================================================================
RCS file: /sources/grub/grub2/ChangeLog,v
retrieving revision 1.248
diff -u -r1.248 ChangeLog
--- ChangeLog   26 Apr 2006 21:58:35 -0000      1.248
+++ ChangeLog   27 Apr 2006 19:08:39 -0000
@@ -1,3 +1,8 @@
+2006-04-27  Vesa Jaaskelainen  <address@hidden>
+
+       * kern/powerpc/ieee1275/init.c (grub_machine_init): Removed
+       duplicated query for IEEE-1275's "/chosen".
+
 2006-04-26  Yoshinori K. Okuji  <address@hidden>
 
        * util/i386/pc/grub-mkimage.c (compress_kernel): Cast arguments
Index: kern/powerpc/ieee1275/init.c
===================================================================
RCS file: /sources/grub/grub2/kern/powerpc/ieee1275/init.c,v
retrieving revision 1.25
diff -u -r1.25 init.c
--- kern/powerpc/ieee1275/init.c        26 Apr 2006 02:20:12 -0000      1.25
+++ kern/powerpc/ieee1275/init.c        27 Apr 2006 19:08:39 -0000
@@ -116,7 +116,6 @@
 grub_machine_init (void)
 {
   char args[256];
-  grub_ieee1275_phandle_t chosen;
   int actual;
   extern char _start;
 
@@ -137,8 +136,7 @@
   grub_ofdisk_init ();
 
   /* Process commandline.  */
-  grub_ieee1275_finddevice ("/chosen", &chosen);
-  if (grub_ieee1275_get_property (chosen, "bootargs", &args,
+  if (grub_ieee1275_get_property (grub_ieee1275_chosen, "bootargs", &args,
                                  sizeof args, &actual) == 0
       && actual > 1)
     {

reply via email to

[Prev in Thread] Current Thread [Next in Thread]