Re: [PATCH] User definable terminfo support

[Omniflux]

Marco Gerards wrote:
> > terminfo-definition-support.diff
> >  * term/terminfo.c: Replaced static vt100 definition with user
> > definable definition support.
>
> Is it possible to do this in a GRUB env. variable, like:
>
> set TERM=vt100
>
> And perhaps one variable or function to set the possible terminal
> descriptions.  I think that would be easier for the user to do it this
> way.

This is possible, however...

The reason I chose to use a linked list allowing multiple terminal 
definitions was so multiple entries could be defined at load time, and, 
ideally, the user could then choose the correct one at boot.

This would be helpful in cases where the choice of definitions is 
unknown to the entity creating the configuration, such as a live CD 
distribution or a generalized system recovery disk for computers without 
video cards.

As to using an env. variable to select which terminal definition to use,
I have not looked at the env. code. I doubt I can tie into the env. code 
to tell when the variable has changed, so this would leave the problem 
of no immediate user feedback if an invalid definition name is set.

If you can point to a good place to provide this feedback, I see no 
problem with changing the selection code to use an environment variable 
instead, but I would like to keep support for multiple terminfo definitions.


Did I interpret your comments correctly?

> give will be more useful than the feedback above...  Can you provide a
> ChangeLog entry so the patch can be reviewed and applied?  See the GNU

Should this be provided as part of the patch, or separate, but with the 
patch email?

> At the moment I am working on the menu code, so the syntax will be
> changed really soon.  But at the moment you can do something like:
>
> title foo
> linux /vmlinux ...
>
> title bar
> ...

I will try this.

Thanks!

--
Omniflux