Re: symbol.h fix for ARM

[Timothy Baldwin]

On Sunday 13 Nov 2005 21:04, Marco Gerards wrote:
> Timothy Baldwin <address@hidden> writes:
> > In ARM GAS syntax "@" marks the start of comment, which breaks symbol.h.
> > I choose double quotes as a replacement as they can't be used to start
> > comments.
> >
> > 2005-11-13  Timothy Baldwin  <address@hidden>
> >
> >         Fix symbol.h for ARM.
> >
> >         * include/grub/symbol.h: (FUNCTION): Use double quotes
> >     instead of "@" which marks the start of a comment on ARM.
> >     (VARIABLE): Likewise.
>
> Have you tested if other archs keep working with this patch applied?

Tested both i386 and PowerPC. I don't see why it should break elsewhere as 
giving double quotes a conflicting meaning would break .string etc. The GAS 
manual does not mention any system dependences.

-- 
Member AFFS, WYLUG, SWP (UK), UAF, RESPECT, StWC
No to software patents!    Victory to the iraqi resistance!

pgpEE2OEnBIrm.pgp
Description: PGP signature