grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [ppc patch] fix line-wrapping


From: Marco Gerards
Subject: Re: [ppc patch] fix line-wrapping
Date: Tue, 08 Nov 2005 19:20:47 +0100
User-agent: Gnus/5.1007 (Gnus v5.10.7) Emacs/21.4 (gnu/linux)

Hollis Blanchard <address@hidden> writes:

> This patch fixes the line-wrapping problems we've been having on
> PPC. I rearranged grub_ofconsole_getwh() slightly to avoid excessive
> indentation. I will apply soon unless people criticize my ChangeLog
> entry. ;)

Great!  This was a very annoying bug.

> Index: ChangeLog
> ===================================================================
> RCS file: /cvsroot/grub/grub2/ChangeLog,v
> retrieving revision 1.193
> diff -u -p -r1.193 ChangeLog
> --- ChangeLog 7 Nov 2005 22:28:55 -0000       1.193
> +++ ChangeLog 8 Nov 2005 04:50:12 -0000
> @@ -1,3 +1,12 @@
> +2005-11-03  Hollis Blanchard  <address@hidden>
> +
> +     * term/ieee1275/ofconsole.c (grub_ofconsole_width): New variable.
> +     (grub_ofconsole_height): Likewise.
> +     (grub_ofconsole_putchar): If grub_curr_x exceeds console width,
> +     manually insert a '\n'.

This won't work if the width can not be read from the firmware.  IIRC
the pegasos has such bug.  I should have a look at that...

Feel free to apply the patch. :-)

Thanks,
Marco





reply via email to

[Prev in Thread] Current Thread [Next in Thread]