Re: play.c

[Hollis Blanchard]

On Nov 5, 2005, at 2:48 PM, Dennis Clarke wrote:

> On 11/5/05, Yoshinori K. Okuji <address@hidden> wrote:
> > On Saturday 05 November 2005 03:17 pm, Vincent Pelletier wrote:
> > > Here is the play command, along with some songs.
> >
> > I point out some stylish mistakes.
>
> Personally I was thrilled with the idea of sound and really, these
> little "style" things are so trivial.  Its like someone hanging a
> painting and then commenting on color of the frame.
>
> Actually I am sure it is just a language barrier issue and what you
> meant to say was "wow, thanks for this cool submission!"

Please don't confuse constructive criticism for disinterest or a lack 
of appreciation. The way code approaches perfection is through peer 
review, and you will notice that almost all patches from all 
contributors are commented on. In fact, most people actively seek out 
criticism for their patches! That is why Vincent posted it to the list 
for comment rather than just committing it himself.

This is how open source works, and I'm sure you'd agree it seems to be 
working pretty well... ;)

-Hollis