grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] DL support on usparc & cls disabling when debugging


From: Hollis Blanchard
Subject: Re: [PATCH] DL support on usparc & cls disabling when debugging
Date: Sat, 22 Oct 2005 22:12:15 -0500

On Oct 22, 2005, at 7:24 AM, Vincent Pelletier wrote:

Vincent Pelletier wrote:
I'll send a separate patch for the .mk & .rmk files, because I have a
lot of dust in those files.

Here they are, along with cache.S
I'll commit those tomorrow if nothing is wrong with those
(conf/sparc64-ieee1275.rmk, conf/sparc64-ieee1275.mk and
kern/sparc64/dl.c, kern/sparc64/cache.S, -kern/sparc64/cache.c).

Especially since your patch affects only sparc64 files, I'd say go right ahead and commit. :)

2005-10-22  Vincent Pelletier <address@hidden>
...
        * conf/sparc64-ieee1275.mk: Generated from sparc64-ieee1275.rmk.

We've been in the habit of simply not mentioning the .mk files: not in the changelog, and not in patches to the list. The diffs are simply too large and not meaningful.

However, when you commit, please do commit the .mk file in addition to the real changes.

Warning: this particular patch you sent has a lot of CVS conflicts in the .mk file. In general please do a build/boot test before sending out a patch... even for "trivial" changes. I've been embarrassed by that a few times myself. :)

-Hollis





reply via email to

[Prev in Thread] Current Thread [Next in Thread]