grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: gzio is broken (fix)


From: Timothy Baldwin
Subject: Re: gzio is broken (fix)
Date: Sun, 16 Oct 2005 10:24:43 +0100
User-agent: KMail/1.8.2

On Saturday 15 Oct 2005 18:34, Yoshinori K. Okuji wrote:
> On Saturday 15 October 2005 10:07 am, Yoshinori K. Okuji wrote:
> > > Problem 2: Reading gzip files all at once results in corruption of the
> > > data. It can be exposed by this patch:
> >
> > Can you investigate this problem?

The patch fixes it:

diff -u -p -r1.2 gzio.c
--- grub2/io/gzio.c   15 Oct 2005 09:22:31 -0000      1.2
+++ grub2/io/gzio.c   16 Oct 2005 08:55:38 -0000
@@ -1193,7 +1193,7 @@ grub_gzio_read (grub_file_t file, char *
        inflate_window (file);

       srcaddr = (char *) ((offset & (WSIZE - 1)) + gzio->slide);
-      size = gzio->saved_offset - file->offset;
+      size = gzio->saved_offset - offset;
       if (size > len)
        size = len;


2005-10-16  Timothy Baldwin <address@hidden>

        * io/gzio.c (grub_gzio_read): Use offset instead of file->offset
        consistently within loop.

> I don't see any problem on my laptop (i386).

Did you apply my test patch and use a test file with an uncompressed size 
larger than 32KiB?


-- 
Member AFFS, WYLUG, SWP (UK), UAF, RESPECT, StWC
No to software patents!    Victory to the iraqi resistance!

Attachment: pgpZttvXeJnkI.pgp
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]