grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: sparc64 port


From: Marco Gerards
Subject: Re: sparc64 port
Date: Sat, 20 Aug 2005 16:10:00 +0200
User-agent: Gnus/5.1007 (Gnus v5.10.7) Emacs/21.3 (gnu/linux)

Vincent Pelletier <address@hidden> writes:

Hi Vincent,

This is really nice!  Thanks a lot.  You asked me on IRC if I can test
if it still builds on the PPC.  I will test that (and let you know on
IRC), after that you can commit the patch if you fix the things I
mention in my email and Okuji mentioned in his.


>       * disk/ieee1275/ofdisk.c (grub_ofdisk_open): use grub_ssize_t
>       instead of int.

Please start sentences with an uppercase letter, same for the other
entries.


Some files are not GPL'ed (cache.c, for example).  The copyright years
are not always correct, like that of ieee1275.h (you wrote it, so it
should be (C) 2005 only).

Can't openfw.c be shared?  I think it can be...

Thanks,
Marco





reply via email to

[Prev in Thread] Current Thread [Next in Thread]