Re: [PATCH] new (mmap support and x86_64 detection)

[Yoshinori K. Okuji]

On Tuesday 16 August 2005 02:49, Ruslan Nikolaev wrote:
> +/* Detect x86_64 CPU */
> +static __inline__ int grub_x86_64_cpu (void)

Can you change this name? This is quoted from 
http://www.autistici.org/grub/moin.cgi/CodingStyle:

Functions

If a function is global, its name must be prefixed with grub_ and must consist 
of only small letters. If the function belongs to a specific function module, 
the name must also be prefixed with the module name. For example, if a 
function is for file systems, its name is prefixed with grub_fs_. If a 
function is for FAT file system but not for all file systems, its name is 
prefixed with grub_fs_fat_. The hierarchy is noted this way.

After a prefix, a function name must start with a verb (such as get or is). It 
must not be a noun. Some kind of abbreviation is permitted, as long as it 
wouldn't make code less readable (e.g. init).

If a function is local, its name may not start with any prefix. It must start 
with a verb. 

Okuji