[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [FILE] Play command
From: |
Yoshinori K. Okuji |
Subject: |
Re: [FILE] Play command |
Date: |
Thu, 14 Jul 2005 10:20:05 +0200 |
User-agent: |
KMail/1.7.2 |
On Wednesday 13 July 2005 23:08, Vincent Pelletier wrote:
> It might require some [f|s]scanf function, and I don't think it is
> welcome in the core just because it is used in such peripheral function.
> I thought first about using such format, because it's way easier to
> edit... But I finally resigned. Maybe a fscanf function could be added
> in this module, then moved in the core if it turns out to be useful.
There is no rule that you must add POSIX-like functions into the kernel. It is
also fine to have libc.mod, if necessary.
> > Is it possible to share this code? We need it for VGA and now for
> > play, we will need it more often for other code which we will write in
> > the future.
>
> Maybe could they be added to kern/i386/pc/startup.S .
No. startup.S should be used only if you must use real mode. In this case, we
use protected mode, so you should add these functions into a C file or a
header. Defining them in a header makes sense, because they are inline
functions.
Okuji