Re: sparc64 port : diffs to powerpc branches

[Vincent Pelletier]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Marco Gerards wrote:
> This is an important test.  Please do not remove it so this code can
> be shared.  Just make sure GRUB_IEEE1275_FLAG_NO_PARTITION_0 is set or
> not set, depending on how OB works.

No problem, I removed it to show that it isn't needed for usparc.

> Can this be done in a way that we can share most (all?) headers
> related to ieee 1275?

I think so, except for some special function, like the term colour one
(I don't think usparc can change colour... Or at least not the same way
ppc does.)

>>Changed some suspicious "&string" to just "string".

Some function with  void * arguments were actualy receiving char *[].
There was no warning about it, but I think there was a leak.
I changed them to char * (dynamically allocated, see next remark :) ).

>>Added malloc calls when size can be known.
> Nice!

More can be done, I haven't done it everywhere.

> Can you write the code so it works on both the PPC and sparc so this
> code can be shared?  Some code you disabled like this has a function
> on the PPC, IIRC.

I think that function works on usparc (not sure though) but as it is not
used at all, I commented it (to get some remarks about it so I can guess
what it's used for :) ).

>>Remove ppc specific partition numbering thing.
> Can you explain this?

It seems that ppc numbers his partitions a special way (ruled by a flag,
so we can make it common to both if the flag is correctly set).

> When you implement this, you can support switching from normal to
> rescue mode and back properly.

There should be a bug in the x86 implementation, that would explain the
unaligned pointer I get when switching to rescue mode from normal mode.

> grub-mkimage is used to add modules to grubof.

So this works, sun partition label & ext2 is read.

> Do you want me to fully review the complete patch or was it just a
> reference for your description?

I think you shouldn't. Once the common parts will have been extracted a
real patch with changelog will be edited.

Vincent Pelletier
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)

iD8DBQFC1CzBFEQoKRQyjtURAicmAJ9ElgCCIk8uxl5K3CVzxejvt/Tz7QCfTyXC
qfT6xq2HLEtGILe/ved1JYA=
=fWNO
-----END PGP SIGNATURE-----

        

        
                
___________________________________________________________________________ 
Appel audio GRATUIT partout dans le monde avec le nouveau Yahoo! Messenger 
Téléchargez cette version sur http://fr.messenger.yahoo.com