grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Small unicode problem fix in normal/menu.c


From: Yoshinori K. Okuji
Subject: Re: [PATCH] Small unicode problem fix in normal/menu.c
Date: Tue, 5 Jul 2005 00:42:25 +0200
User-agent: KMail/1.7.2

On Sunday 03 July 2005 22:52, Vincent Pelletier wrote:
> There is an alignment problem when menu is drawn with Unicode chars in
> titles : there aren't enough spaces written on the right to make the
> hilight fill horizontaly the menu.

You can check in this patch, but this is not the right thing to do. At the 
moment, it is impossible to know how many columns will be occupied by putting 
a byte until it is actually putted. This is very bad, and, of course, does 
not work well in some cases.

So, as I described before, it is necessary to implement a new function which 
returns the width for a given (Unicode) character. For the menu, I think it 
would be easier to convert all strings to Unicode strings before rendering. 
Writing bytes is very, very hard.

Okuji




reply via email to

[Prev in Thread] Current Thread [Next in Thread]