[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [ppc] [patch] more cleanups
|
From: |
Marco Gerards |
|
Subject: |
Re: [ppc] [patch] more cleanups |
|
Date: |
Wed, 11 May 2005 08:37:27 +0200 |
|
User-agent: |
Gnus/5.1007 (Gnus v5.10.7) Emacs/21.3 (gnu/linux) |
Hollis Blanchard <address@hidden> writes:
>>> /* Where grub-mkimage places the core modules in memory. */
>>> -#define GRUB_IEEE1275_MODULE_BASE 0x0300000
>>> +#define GRUB_IEEE1275_MODULE_BASE 0x00300000
>>
>> Huh? Can you explain this? I would even prefer:
>>
>> #define GRUB_IEEE1275_MODULE_BASE 0x300000
>
> What is to explain? The address has 7 chars in it when it should have
> 8. The leading zeroes make it easier to read.
Ok, that makes sense.
>> Does loading linux with an initrd still work?
>
> I said it did...
I must have missed that, sorry.
Feel free to commit your patch.
Thanks,
Marco