|
From: | Hollis Blanchard |
Subject: | Re: [ppc] [patch] more cleanups |
Date: | Tue, 10 May 2005 17:34:02 -0500 |
On May 10, 2005, at 1:01 PM, Marco Gerards wrote:
Hollis Blanchard <address@hidden> writes:--- include/grub/powerpc/ieee1275/kernel.h 4 Jan 2005 14:01:45 -0000 1.1+++ include/grub/powerpc/ieee1275/kernel.h 10 May 2005 01:27:36 -0000 @@ -21,6 +21,6 @@ #define GRUB_KERNEL_MACHINE_HEADER 1 /* Where grub-mkimage places the core modules in memory. */ -#define GRUB_IEEE1275_MODULE_BASE 0x0300000 +#define GRUB_IEEE1275_MODULE_BASE 0x00300000Huh? Can you explain this? I would even prefer: #define GRUB_IEEE1275_MODULE_BASE 0x300000
What is to explain? The address has 7 chars in it when it should have 8. The leading zeroes make it easier to read.
Index: loader/powerpc/ieee1275/linux.c[...]- initrd_addr = 0xc0000000; + initrd_addr = 0;Does loading linux with an initrd still work?
I said it did... -Hollis
[Prev in Thread] | Current Thread | [Next in Thread] |