Re: [patch] PPC cleanups

[Marco Gerards]

Hollis Blanchard <address@hidden> writes:

Hi Hollis,

Here is my final report.  I have tested your patch on the PegasosII.
I assume you properly tested it on the G3.  You can check in your
patch if you make the changes I proposed in this and my previous
email.  Please update the copyright years of the files you changes, if
they are not set correctly.

> +  grub_ieee1275_finddevice ("/openprom", &openprom);
> +  smartfw = grub_ieee1275_get_property (openprom, "SmartFirmware-version",
> +                            0, 0, 0);

Please align the make sure `0, 0, 0' are properly aligned with
`openprom, "SmartF...'.

> +  if (smartfw)
> +    grub_ieee1275_set_flag (GRUB_IEEE1275_0_BASED_PARTITIONS);

This did not work on the PegasosII.  I fixed this by changing this
test to:

if (smartfw == 0)
  grub_ieee1275_set_flag (GRUB_IEEE1275_0_BASED_PARTITIONS);

Thanks,
Marco