Re: [patch] PPC build fixes

[Hollis Blanchard]

On Mar 24, 2005, at 3:41 PM, Marco Gerards wrote:

> Hollis Blanchard <address@hidden> writes:
> >         (grub_halt_init): New function.
> >         (grub_halt_fini): Likewise.
>
> Why do you need this?
>
> >         (grub_reboot_init): New function.
> >         (grub_reboot_fini): Likewise.
>
> Same here.

Because these commands need to be accessible from grub-emu (that is how 
you quit).

> >         * include/grub/powerpc/ieee1275/init.h: Remove inaccurate
> >         comment.
>
> Can you change the comment to something sane?

include/grub/i386/pc/init.h has no comment, and I don't know how to 
describe this anyways:
        void cmain (uint32_t r3, uint32_t r4, uint32_t r5);
        void grub_ofdisk_init (void);
        void grub_console_init (void);

"A tiny bit of miscellaneous stuff"? "Things related to booting"?

> >         * util/powerpc/ieee1275/misc.c (grub_reboot): New function.
> >         (grub_halt): Likewise.
>
> Isn't this just a completely new file?

Er, yes, sorry. :)

-Hollis