Re: Grub2 on Mac OS X

[Yoshinori K. Okuji]

On Monday 21 March 2005 07:55 pm, Antoine Terrienne wrote:
> Here is a patch with the modifications I made. Please tell me if some of
> them are wrong. I hope I would help.

Could you make a patch with -u? The standard diff format is too difficult for 
me.

I describe what I think are not appropriate in your patch:

- memalign should not be just a macro. memalign is not the same as malloc.

- The macro _MACOSX_ should not be defined. OS-specific code should be enabled 
in a more generic way. Take a look at the autoconf manual and the autobook 
<http://sources.redhat.com/autobook/>.

- Rather than replacing argp with getopt, please include the standalone 
version of argp <http://gd.tuwien.ac.at/utils/shells/lsh/>.

- ChangeLog, please.

Okuji