Re: [PATCH] dprintf implementation

[Hollis Blanchard]

On Feb 21, 2005, at 3:04 PM, Vincent Pelletier wrote:
> Here is the dprintf function I worked on 2 weeks ago, which I fixed 
> this
> evening.

Your mailer did some bad stuff to this patch again...

> Index: kern/misc.c
> ===================================================================
> RCS file: /cvsroot/grub/grub2/kern/misc.c,v
> retrieving revision 1.18
> diff -u -p -r1.18 misc.c
> - --- kern/misc.c       19 Feb 2005 20:56:07 -0000      1.18
> +++ kern/misc.c 21 Feb 2005 20:38:38 -0000
> @@ -128,6 +128,18 @@ grub_printf (const char *fmt, ...)
> ~   return ret;
> ~ }
>
> +void
> +grub_real_dprintf(const char *file, const int line, const char *title,
> +                  const char *fmt, ...)
> +{
> +  va_list args;
> +
> +  grub_printf ("%s,%d (%s): ", file, line, title);
> +  va_start (args, fmt);
> +  grub_vprintf (fmt, args);
> +  va_end (args);
> +}
> +
> ~ int
> ~ grub_vprintf (const char *fmt, va_list args)
> ~ {

Weren't we going to have various flags to selectively enable debug 
messages from particular components at runtime? That's the most 
important thing to me: to be able to debug a user's mysterious problem 
by telling them "use debug=filesystem and send me the output".

-Hollis