grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] normal/cmdline.c : history contains empty lines


From: Marco Gerards
Subject: Re: [PATCH] normal/cmdline.c : history contains empty lines
Date: Wed, 29 Dec 2004 21:06:55 +0000
User-agent: Gnus/5.1006 (Gnus v5.10.6) Emacs/21.3 (gnu/linux)

Vincent Pelletier <address@hidden> writes:

> The empty string could be checked using a buf[0]==0 instead of
> calling grub_strlen as I did (faster, but maybe less portable in
> case of wide chars).

Yeah, but this makes it more readable.  Speed is not really an issue
in handling a command line. :)

> grub_history_add should be moved after the while loop too.

In my code?

--
Marco





reply via email to

[Prev in Thread] Current Thread [Next in Thread]