Re: GRUB2: *BSD and more patch

[Marco Gerards]

Sergey Matveychuk <address@hidden> writes:

> Yoshinori K. Okuji wrote:
>
>> So, regardless of your OS, let's use:
>> if (S_ISREG (st.st_mode))
>>   return make_device_name (drive, -1, -1);
>> The same applies to other places where S_ISBLK is used.
>
> It's quite strange in util/i386/pc/getroot.c:
> if (!S_ISREG (st.st_mode) && st.st_rdev == dev)

This patch is still not applied.  What are the issues and what needs
to be done before it can be committed?

Can't this code be changed like Okuji suggested and be committed?

Thanks,
Marco