Re: JFS support (PATCH) and filesystem improvements

[Yoshinori K. Okuji]

On Saturday 28 August 2004 19:47, Marco Gerards wrote:
> Committed.

Thank you.

> And here is a patch for that.
>
> To avoid code duplication I wrote kern/fshelp.c, which has the
> following two functions:

That is a good idea, but why are the functions in the kernel? Imagine 
that GRUB 2 supports TFTP and the user uses GRUB as a network-based 
loader. Probably the user does not have to compile the helper 
functions, because network-based filesystems are very different at the 
implementation level.

So I think they should be in a module rather than the kernel. fshelp.mod 
sounds good for me.

Okuji