groff
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

CHECKSTYLE: Report problems with a non-zero status


From: Alejandro Colomar (man-pages)
Subject: CHECKSTYLE: Report problems with a non-zero status
Date: Mon, 31 Jan 2022 00:41:09 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.1

Hi Branden,

I started using groff(1)'s -rCHECKPATCH=3 in my chessutils game suite
(consisting of exactly 1 game right now :~).  See
<http://www.alejandro-colomar.es/src/alx/alx/games/chessutils.git/commit/?id=5c2ec7eecf7a3a9856fa25b951bbcf473a08d002>

As with C static analyzers, I added it to the makefile, so that I run
`make analyze` and see if there's any problem with the code.  Ideally,
I'll get nothing on standard error, an exit status of 0, _and_ some
dummy files to mark the success to make(1).  If there's any problem,
I'll get something on stderr, I'll get an exit status of something
non-zero, _and_ the dummy files will not be created, so that make(1)
warns me again and again.  If I overlook an error once, I'll keep
getting it, instead of believing that it's still there.

But groff(1) doesn't error out when it finds some problematic code, so
I'll see some shy error on standard error once, but then if I run
make(1) again, I'll believe that everything is OK.

So, my suggestion is to return non-zero when -rCHECKSTYLE reports something.

Does it make sense?

Thanks,

Alex


-- 
Alejandro Colomar
Linux man-pages comaintainer; https://www.kernel.org/doc/man-pages/
http://www.alejandro-colomar.es/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]