FWD: [bug #59268] [PATCH] tmac.am: non-portable $< syntax

[Ingo Schwarze]

Hi Branden,

given that we are working towards release, i started testing on
non-Linux platforms, first on OpenBSD.  After that, i'm planning
to test on Oracle Solaris 11 and on SUN Solaris 10.

This is the first (but not the only) fatal issue i found.
I'm looking for an OK to push the fix.

No Changelog entry is needed because the bug was never released
and the patch doesn't change functionality but merely fixes the
build.

Yours,
  Ingo

----- Forwarded message from Ingo Schwarze -----

URL:
  <https://savannah.gnu.org/bugs/?59268>

                 Summary: [PATCH] tmac.am: non-portable $< syntax
                 Project: GNU troff
            Submitted by: schwarze
            Submitted on: Wed 14 Oct 2020 11:56:23 AM UTC
                Category: Macro - man
                Severity: 3 - Normal
              Item Group: Build/Installation
                  Status: None
                 Privacy: Public
             Assigned to: schwarze
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: [1.23]

    _______________________________________________________

Details:

Groff no longer builds with POSIX make(1):

$ make
make  all-am
Using $< in a non-suffix rule context is a GNUmake idiom (Makefile:12441)
*** Error 2 in /co/groff/build (Makefile:5317 'all')

This was broken in:
commit 31536c517dfe49b4e4a715a732f76b701531e90a
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Wed Aug 12 00:02:51 2020 +1000

The attached patch fixes the error.

    _______________________________________________________

commit a5c5868e3ec7b996129b4f5e8ea63304b55cfbc2
Author: Ingo Schwarze <schwarze@openbsd.org>
Date:   Wed Oct 14 13:52:29 2020 +0200

    tmac.am: do not use $< in a non-portable way

diff --git a/tmac/tmac.am b/tmac/tmac.am
index de5d1746..05eb259e 100644
--- a/tmac/tmac.am
+++ b/tmac/tmac.am
@@ -207,14 +207,14 @@ M4WORDS = 
define|divert|include|index|shift|undefine|undivert
 M4CHECK = tmac/check-groff_man-stamp
 
 $(M4CHECK): tmac/groff_man.7.man.in
-       ! grep -E '(^|[[:space:]])($(M4WORDS))($$|[[:space:]])' $<
-       > $@
+       ! grep -E '(^|[[:space:]])($(M4WORDS))($$|[[:space:]])' \
+         $(tmac_srcdir)/groff_man.7.man.in > $@
 
 tmac/groff_man.7.man: tmac/groff_man.7.man.in $(M4CHECK)
-       m4 -D_groff_man_not_style $< > $@
+       m4 -D_groff_man_not_style $(tmac_srcdir)/groff_man.7.man.in > $@
 
 tmac/groff_man_style.7.man: tmac/groff_man.7.man.in $(M4CHECK)
-       m4 -D_groff_man_style $< > $@
+       m4 -D_groff_man_style $(tmac_srcdir)/groff_man.7.man.in > $@
 
 # The installation of groff compatibility wrappers for vendor-provided
 # non-GNU macro sets is controlled by 'compatibility_wrappers' (see the