groff
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [groff] Release Candidate 1.22.4.rc3


From: G. Branden Robinson
Subject: Re: [groff] Release Candidate 1.22.4.rc3
Date: Sun, 4 Nov 2018 01:18:32 -0400
User-agent: NeoMutt/20180716

At 2018-11-04T02:25:37+0100, Bertrand Garrigues wrote:
> Apologies for my long silence; due to personal problems I wasn't able to
> work on groff these last months.

Hi Bertrand,

I hope things are getting better for you!

> Version 1.22.4.rc2 no longer build on my environment (Archlinux) because
> of glibc 2.28 (fixed by 1c8c0210bded9e78c2748753c17fc9d9b07b0089) so
> I've just made a 1.22.4.rc3 version.  I need to check the issue on
> 'contrib/hdtbl' pointed out by Branden before pushing an official
> release.

I'd like to propose resolving the following 4 issues before going final.

1. Resolve this compiler warning:

../src/roff/troff/input.cpp: In function ‘void macro_source()’:
../src/roff/troff/input.cpp:7716:11: warning: ‘char* strncat(char*, const 
char*, size_t)’ specified bound depends on the length of the source argument 
[-Wstringop-overflow=]
    strncat(s, fn, strlen(fn) - sizeof(MACRO_POSTFIX) + 1);
    ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../src/roff/troff/input.cpp:7716:25: note: length computed here
    strncat(s, fn, strlen(fn) - sizeof(MACRO_POSTFIX) + 1);
                   ~~~~~~^~~~

2. Revert the 3 changes Ingo made to hdtbl in August; unfortunately they
had bad side-effects, producing warnings and causing some documents to
not generate correctly.  (It may be better to think of
contrib/hdtbl/examples as contrib/hdtbl/test-suite.)

3. Resolve Savannah #40967.  I told Dave K. I'd work on this back on
February but I let it drop.  It is not a big patch, and only affects the
"me" macro package documentation.  Maybe we can even get a French
translation before 1.22.4 final (it's only a few words).

https://savannah.gnu.org/bugs/?40967

I'll work on this first as it requires no research.

4. Apply the final pass of my groff_man.7 overhaul.  IIRC I sent this
privately to you and Ingo a few months ago; I have tweaked it very
little sense, so I reckon I'm happy with it.  All it needs now is a
commit message and ChangeLog entry.

Please find it attached.

-- 
Regards,
Branden

Attachment: groff_man.7.man.diff
Description: Text Data

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]