groff
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Groff] problem with preconv and sample_docs.mom


From: Bertrand Garrigues
Subject: Re: [Groff] problem with preconv and sample_docs.mom
Date: Sun, 05 Nov 2017 22:06:51 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux)

On Sun, Nov 05 2017 at 04:13:22 PM, Ralph Corderoy <address@hidden> wrote:
> Hi Branden,
>
>> >    if (len == 0)
>> >        goto end;
>>
>> We're kind of giving a hostage to fortune here, aren't we?
>> https://en.wikipedia.org/wiki/Unreachable_code#goto_fail_bug
>
> The whole code base skips braces so is goto worth special casing?  It's
> just as likely to be removed in some future edit because it doesn't
> match house style.  :-)  Besides, things like gcc's
> -Wmisleading-indentation will complain if another indented statement is
> added.

OK so I've commited on master,

Regards,

Bertrand Garrigues



reply via email to

[Prev in Thread] Current Thread [Next in Thread]