groff
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Groff] can't translate character code 229 to special character `oa'


From: Eli Zaretskii
Subject: Re: [Groff] can't translate character code 229 to special character `oa' in transparent throughput
Date: Thu, 11 Jun 2015 16:02:10 +0300

> From: Deri James <address@hidden>
> Date: Wed, 10 Jun 2015 17:02:22 +0100
> Cc: groff <address@hidden>
> 
> I will patch pdfmom soon.

I've looked at that script and found 2 portability issues there.
Please consider the following patch, which solves them: (a) use of a
literal ':' character as PATH separator, and (b) shell quoting that
only works with a Posix shell.

Thanks.

--- pdfmom~     2014-11-08 18:11:30.000000000 +0200
+++ pdfmom      2015-06-11 10:56:10.000000000 +0300
@@ -24,13 +24,14 @@
 # along with this program. If not, see <http://www.gnu.org/licenses/>.
 
 use strict;
+use Config;
 use File::Temp qw/tempfile/;
 my @cmd;
 my $dev='pdf';
 my $preconv='';
 my $readstdin=1;
 
-$ENV{PATH}=$ENV{GROFF_BIN_PATH}.':'.$ENV{PATH} if exists($ENV{GROFF_BIN_PATH});
+$ENV{PATH}=$ENV{GROFF_BIN_PATH}.$Config{path_sep}.$ENV{PATH} if 
exists($ENV{GROFF_BIN_PATH});
 $ENV{TMPDIR}=$ENV{GROFF_TMPDIR} if exists($ENV{GROFF_TMPDIR});
 
 while (my $c=shift)
@@ -122,7 +123,7 @@
 
 if ($dev eq 'pdf')
 {
-    system("groff -Tpdf -dPDF.EXPORT=1 -mom -z $cmdstring 2>&1 | grep '^\.ds' 
| groff -Tpdf -mom - $preconv $cmdstring");
+    system("groff -Tpdf -dPDF.EXPORT=1 -mom -z $cmdstring 2>&1 | grep 
\"^\.ds\" | groff -Tpdf -mom - $preconv $cmdstring");
 }
 elsif ($dev eq 'ps')
 {



reply via email to

[Prev in Thread] Current Thread [Next in Thread]