Re: [Groff] [groff] 01/01: Correctly handle `MAKEINFO' environment variable. Bug introduced in commit from 2014-03-29.

[Steffen Nurpmeso]

Hello Werner,

Werner LEMBERG <address@hidden> wrote:
 |Author: Werner Lemberg <address@hidden>
 |Date:   Sun Oct 12 10:58:01 2014 +0200
 |
 |    Correctly handle `MAKEINFO' environment variable.
 |    Bug introduced in commit from 2014-03-29.
 |    
 |    * m4/groff.m4 (GROFF_MAKEINFO): Don't set MAKEINFO to empty string
 |    before actually testing it.

oops [1]:

  AC_CHECK_PROG (variable, ..

  Check whether program prog-to-check-for exists in path. [.]

  If variable was already set, do nothing. [.]

This is what you're fixing here? !
Sorry!!
But then -- shouldn't there even be a "unset MAKEINFO"?

  [1] 
<https://www.gnu.org/software/autoconf/manual/autoconf-2.68/html_node/Generic-Programs.html>

 |Author: Werner Lemberg <address@hidden>
 |Date:   Sun Oct 12 11:11:01 2014 +0200
 |
 |    [doc] Improve call to generation of `groff.pdf'.
 |    Problem reported by Axel Kielhorn <address@hidden>.
 |    
 |    Since `groff.texinfo' contains latin-1 characters, some sed
 |    implementations (like the one used on Mac OS 10.8) fail if called
 |    with the wrong locale.  Basically, this is a `texi2dvi' bug, but we
 |    can set `LANG' by ourselves to improve the situation.

 | groff_bin_dirs=\
 |@@ -101,9 +102,9 @@ imagedir=img
 | .texinfo.txt:
 |  LANG= $(MAKEINFO) --enable-encoding -I$(srcdir) --plaintext -o $@ $<
 | .texinfo.dvi:
 |-     MAKEINFO=$(MAKEINFO) $(TEXI2DVI) -e $<
 |+     LANG= MAKEINFO=$(MAKEINFO) $(TEXI2DVI) -e $<
 | .texinfo.pdf:
 |-     MAKEINFO=$(MAKEINFO) $(TEXI2DVI) -e --pdf $<
 |+     LANG= MAKEINFO=$(MAKEINFO) $(TEXI2DVI) -e --pdf $<

And i would be interested why you favor LANG= over LC_ALL=, given
that POSIX defines LANG= as "third-class" behind LC_ALL= and also
the other LC_* variables?

Thanks and again sorry, i really didn't dig deep into auto*...

--steffen