Re: [Groff] new automake system

[Bertrand Garrigues]

Ulrich,

On Fri, Sep 26 2014 at 12:15:22 PM, Ulrich Lauther <address@hidden> wrote:
> On Fri, Sep 26, 2014 at 10:52:49AM +0200, Bertrand Garrigues wrote:
>> Calling 'make clean' or 'make distclean' fixed your problem. The error
>> message you got (missing file in site-font) is normal and comes from the
>> additional traces I gave you. We first try to use the fonts in site-font
>> in priority (directory where the user can manually add its own fonts),
>> and then only the default directory in share/groff/1.22.2/font/devps.
>> 
> As I understand the patch leads to termination when the file is not
> found in site-font.
> Wouldn't it be better to terminate only after all
> possible places have been checked and then give a message "DESC could
> neither be found in site-font nor in /share/groff/1.22.2/font" or
> similar and then keep this code in the official version?

No, the patch was just adding traces, it does not modify the
behaviour. I found it easier to trace in the function open_file, which
is used to search for font files in the default directory and in the
site-font directory. Having the error "failed to open ..." doesn't mean
that you have a problem, and does not lead to termination.

Anyway this patch was for debugging, definitively not for commit.

Regards,

--
Bertrand Garrigues