groff
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Groff] Potential buffer overrun in src/roff/troff/input.cpp


From: Werner LEMBERG
Subject: Re: [Groff] Potential buffer overrun in src/roff/troff/input.cpp
Date: Wed, 24 Sep 2014 11:41:56 +0200 (CEST)

> Should I also s?\*?/?g, on the lead-in to the function header
> comment block, (in addition to introducing each subsequent line with
> the C++ style '//')?

Even after reading it twice I'm not exactly sure what you mean :-)
Please show an example.

>>> + * Returns (+ve) number of input characters stored into caller's
>> 
>> What is `+ve'?
> 
> I've always understood it to be universally accepted -- at least in
> mathematical, scientific, and engineering circles -- as an
> abbreviation for "positive".

I'm quite firm in reading such stuff, and up to now I've *never* seen
this.  So please simply say `positive'.  In general, I think we are
using far too much abbreviations everywhere...

> Maybe the comment could be more explicit?

Everything else looks fine, thanks.


    Werner



reply via email to

[Prev in Thread] Current Thread [Next in Thread]