Re: [Groff] new automake system

[Bertrand Garrigues]

Hi Bernd,

On Mon, Sep 22 2014 at 08:52:55 PM, "Bernd Warken" <address@hidden> wrote:
> ### ./test-suite.log:
>
> FAIL: contrib/gdiffmk/tests/gdiffmk_tests.sh
>
> /opt/development/groff/git/automake/patched/build/../contrib/gdiffmk/tests/runtests.sh:
> 50:
> /opt/development/groff/git/automake/patched/build/../contrib/gdiffmk/tests/runtests.sh:
> function: not found

On which environment are you working, perhaps a Debian-based distro with
dash as the default shell ? It seems that the file
contrib/gdiffmk/tests/runtests.sh has a bashism. You should have the same
problem on master. Does it work better with the attached patch ?

>> What version of texinfo are you using ? I reproduced this problem with
>> texinfo 5.2. The problem is that the macro @LE{} works correctly with
>> texinfo 4.13, but not texinfo 5.2. I have the same problem on master,
>> the difference is that groff.pdf is not built by default, you have
>> manually build it:
>
> I have texinfo 5.2 and applied your patch for groff.texi.
>  
>>   $ cd build/doc
>>   $ make groff.pdf
>  
> This dows not work for me

Do you mean the patch on the groff.texi does not work on the automake2
branch, or that building groff.pdf on master with the 2 commands I gave
you doees not work ?  

Note: On the automake2 branch you build groff.pdf automatically when
launching 'make distcheck', but you can also test this if you type 'make
pdf' in your build directory.

diff --git a/contrib/gdiffmk/tests/runtests.sh 
b/contrib/gdiffmk/tests/runtests.sh
index e41cffe..9fbad83 100755
--- a/contrib/gdiffmk/tests/runtests.sh
+++ b/contrib/gdiffmk/tests/runtests.sh
@@ -47,7 +47,7 @@ run   Run the tests.
        ;;
 esac
 
-function TestResult {
+TestResult () {
        if cmp -s $1 $2
        then
                echo $2 PASSED

--
Regards,

Bertrand Garrigues