groff
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Groff] [patch] unbreak make install


From: Ingo Schwarze
Subject: [Groff] [patch] unbreak make install
Date: Sat, 21 Jun 2014 23:12:57 +0200
User-agent: Mutt/1.5.21 (2010-09-15)

Hi,

currently, when you build a distribution tarball with "make dist",
extract that, configure and make, then the "make install" crashes
because the tarball lacks two directories that were recently
added by Bernd Warken.

The patch below fixes the issue.


Regarding the background:
To be able to closely monitor groff development, in particular to
make sure that mandoc(1) doesn't inadvertently go into some direction
conflicting with recent developments in groff, I have built myself
an OpenBSD port of bleeding edge groff, always relying on the latest
code from the git master branch.  I haven't published that port and
don't know whether it would be useful for anyone else, but i don't
consider it secret either in case anybody is interested: just ask
for it if you want it.

It is certainly nice to see when upstream groff development makes
progress.  However, i would consider it common practice for
upstream committers to test the build before committing, rather
than relying on downstream consumers to catch trivial build system
bugs...  It is actually easier to catch such bugs right away before
committing because you know what you are changing, so you know where
to look if something breaks, while the search space for downstream
followers is a lot larger.

Thanks,
  Ingo


2014-06-21  Ingo Schwarze  <address@hidden>

        * Makefile.in: Unbreak make install:
        Add missing gideal dirs to the dist tarball.


commit ec7cf4a2b06b21431fe576cc96960b1b5f1d2309
Author: Ingo Schwarze <address@hidden>
Date:   Sat Jun 21 23:06:17 2014 +0200

    unbreak make install: add missing gideal dirs to the dist tarball

diff --git a/Makefile.in b/Makefile.in
index dd927c7..8e6aed7 100644
--- a/Makefile.in
+++ b/Makefile.in
@@ -714,6 +714,8 @@ NOMAKEDIRS=\
   arch/djgpp \
   contrib/chem/examples \
   contrib/chem/examples/122 \
+  contrib/gideal/files \
+  contrib/gideal/libfiles \
   contrib/groffer/perl \
   contrib/groffer/shell \
   contrib/hdtbl/examples \



reply via email to

[Prev in Thread] Current Thread [Next in Thread]