groff
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Groff] groff repo conversion in progress


From: Werner LEMBERG
Subject: Re: [Groff] groff repo conversion in progress
Date: Tue, 26 Nov 2013 08:29:06 +0100 (CET)

> transform 1..$ /^\n\* (.*)\n\n$/\n\1\n\n/
> 
> The reason for this is that I think it would be good if leading '*'
> in a gitk list of first lines were a visual warning that the
> following comment is "old style" - fails to obey git conventions
> 
> The policy question is: are you OK with me editing the history that
> much? Some people would not be.  It's another level of intrusiveness
> up from just tweaking whitespace.

Please leave it as-is.  Looking into groff's ChangeLog file, the
number of such commits is quite small.  Additionally, even with my git
repositories that contain a manually maintained ChangeLog file, I got
into the habit of preserving the leading star in the (single-line)
commit message if it directly addresses a file.

For example, in the FreeType repository I've recently written

  * src/sfnt/ttsbit.c (tt_sbit_decoder_load_bitmap): Typo.

while a more `global' commit summary looks like

  Simplify header file hierarchy.

I can imagine that a new maintainer changes this (probably generating
the ChangeLog file from the git messages automatically), but for the
groff case I prefer consistency over convention.


    Werner



reply via email to

[Prev in Thread] Current Thread [Next in Thread]