Re: [Groff] [Groff-commit] groff ChangeLog INSTALL.gen Makefile.in Makefil...

[Werner LEMBERG]

>> If you break a line, please start the new line with the operator:
>> 
>>   -test -d "$(DESTDIR)$(bindir)" \
>>            || $(mkinstalldirs) "$(DESTDIR)$(bindir)";
> 
> (Interesting.  I have binary operators at the end of the line as,
> like a hyphen in text, they indicate there's more to follow.)

Starting with the operator is GNU style, AFAIK, and it is used
throughout the groff code.

>>              $(srcdir)/grog.pl >$@; \
>>      chmod +x $@;
> 
> The former will have make(1) stop if grog.pl fails whereas the
> latter will ignore that and use chmod's success.  `&&' would avoid
> this in the latter though I wonder, without context, if the two
> commands need to be in the one sh invocation?  Both create $@ even
> on failure, perhaps causing the target to be considered `built' next
> time.  `grog.pl >address@hidden && mv address@hidden $@' might help.

Feel free to improve that :-)  The `\' has been there previously, and
I always try to go the route of least surprise, this is, being as
minimally invasive as possible.


    Werner